Release: Patch 8.3.7 #29410
Open
Release: Patch 8.3.7 #29410
+43
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
requested review from
kylegach and
jonniebigodes
as code owners
github-actions
bot
added
the
release
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
5 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
| const decl = _findVarDeclarator(localName, parent as t.Program) as any; | ||
| self._exports[exportName] = decl.init; | ||
| self._exportDecls[exportName] = decl; | ||
| // decl can be empty in case X from `import { X } from ....` because it is not handled in _findVarDeclarator |
There was a problem hiding this comment.
style: Consider adding a comment explaining why decl can be empty in this case
storybook-bot
force-pushed
the
version-patch-from-8.3.6
branch
4 times, most recently
from
e04b8d3
to
2a04f46
Compare
storybook-bot
force-pushed
the
version-patch-from-8.3.6
branch
from
2a04f46
to
e9bdb92
Compare
ConfigFile: Fix `export { X }` parsing
(cherry picked from commit 3b4318f)
storybook-bot
force-pushed
the
version-patch-from-8.3.6
branch
from
e9bdb92
to
3d87285
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated pull request that bumps the version from
8.3.6to8.3.7.Once this pull request is merged, it will trigger a new release of version
8.3.7.If you're not a core maintainer with permissions to release you can ignore this pull request.
To do
Before merging the PR, there are a few QA steps to go through:
And for each change below:
This is a list of all the PRs merged and commits pushed directly to
next, that will be part of this release:export { X }parsing #29344If you've made any changes doing the above QA (change PR titles, revert PRs), manually trigger a re-generation of this PR with this workflow and wait for it to finish. It will wipe your progress in this to do, which is expected.
Feel free to manually commit any changes necessary to this branch after you've done the last re-generation, following the Make Manual Changes section in the docs, especially if you're making changes to the changelog.
When everything above is done:
Generated changelog
8.3.7
export { X }parsing - #29344, thanks @vctqs1!