-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI: Use ink
in CLI
#30202
Draft
ndelangen
wants to merge
130
commits into
next
Choose a base branch
from
norbert/cli-with-ink
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
CLI: Use ink
in CLI
#30202
+4,297
−790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
View your CI Pipeline Execution ↗ for commit 4302698.
☁️ Nx Cloud last updated this comment at |
Package BenchmarksCommit: The following packages have significant changes to their size or dependencies:
|
Before | After | Difference | |
---|---|---|---|
Dependency count | 60 | 60 | 0 |
Self size | 832 KB | 846 KB | 🚨 +14 KB 🚨 |
Dependency size | 14.19 MB | 14.19 MB | 🚨 +102 B 🚨 |
Bundle Size Analyzer | Link | Link |
@storybook/core
Before | After | Difference | |
---|---|---|---|
Dependency count | 54 | 55 | 🚨 +1 🚨 |
Self size | 19.09 MB | 19.64 MB | 🚨 +555 KB 🚨 |
Dependency size | 14.43 MB | 14.72 MB | 🚨 +290 KB 🚨 |
Bundle Size Analyzer | Link | Link |
storybook
Before | After | Difference | |
---|---|---|---|
Dependency count | 55 | 56 | 🚨 +1 🚨 |
Self size | 22 KB | 24 KB | 🚨 +2 KB 🚨 |
Dependency size | 33.52 MB | 34.37 MB | 🚨 +845 KB 🚨 |
Bundle Size Analyzer | Link | Link |
sb
Before | After | Difference | |
---|---|---|---|
Dependency count | 56 | 57 | 🚨 +1 🚨 |
Self size | 1 KB | 1 KB | 0 B |
Dependency size | 33.54 MB | 34.39 MB | 🚨 +847 KB 🚨 |
Bundle Size Analyzer | Link | Link |
@storybook/cli
Before | After | Difference | |
---|---|---|---|
Dependency count | 399 | 407 | 🚨 +8 🚨 |
Self size | 503 KB | 248 KB | 🎉 -255 KB 🎉 |
Dependency size | 75.57 MB | 77.68 MB | 🚨 +2.11 MB 🚨 |
Bundle Size Analyzer | Link | Link |
@storybook/codemod
Before | After | Difference | |
---|---|---|---|
Dependency count | 277 | 278 | 🚨 +1 🚨 |
Self size | 612 KB | 612 KB | 0 B |
Dependency size | 65.38 MB | 66.23 MB | 🚨 +853 KB 🚨 |
Bundle Size Analyzer | Link | Link |
create-storybook
Before | After | Difference | |
---|---|---|---|
Dependency count | 113 | 150 | 🚨 +37 🚨 |
Self size | 1.11 MB | 1.91 MB | 🚨 +803 KB 🚨 |
Dependency size | 42.66 MB | 47.20 MB | 🚨 +4.54 MB 🚨 |
Bundle Size Analyzer | Link | Link |
…t reproduce locally
…/storybook into norbert/cli-with-ink
…it will handle the telemetry notification itself
…/storybook into norbert/cli-with-ink
…y we can accurately detect the user passing the flag, and skip the step
…/storybook into norbert/cli-with-ink
…/storybook into norbert/cli-with-ink
…/storybook into norbert/cli-with-ink
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
What I did
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This pull request has been released as version
0.0.0-pr-30202-sha-958e81ef
. Try it out in a new sandbox by runningnpx [email protected] sandbox
or in an existing project withnpx [email protected] upgrade
.More information
0.0.0-pr-30202-sha-958e81ef
norbert/cli-with-ink
958e81ef
1737618011
)To request a new release of this pull request, mention the
@storybookjs/core
team.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=30202