Skip to content

Commit

Permalink
Merge pull request #793 from storybuilder-org/StoryNodeItemLogging
Browse files Browse the repository at this point in the history
Story node item logging
  • Loading branch information
terrycox authored Aug 30, 2024
2 parents 51d2ba3 + 0dfd4db commit 326fbcf
Show file tree
Hide file tree
Showing 2 changed files with 30 additions and 3 deletions.
6 changes: 3 additions & 3 deletions StoryCADLib/ViewModels/StoryNodeItem.cs
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,7 @@ public StoryNodeItem(ILogService logger, StoryElement node, StoryNodeItem parent

// Overloaded constructor without logger
public StoryNodeItem(StoryElement node, StoryNodeItem parent,
StoryItemType type = StoryItemType.Unknown) : this(null, node, parent, type)
StoryItemType type = StoryItemType.Unknown) : this(Ioc.Default.GetRequiredService<ILogService>(), node, parent, type)
{
}

Expand Down Expand Up @@ -408,13 +408,13 @@ public StoryNodeItem(ILogService logger, StoryNodeItem parent, IXmlNode node)
}

// Overloaded constructor without logger
public StoryNodeItem(StoryNodeItem parent, IXmlNode node) : this(null, parent, node)
public StoryNodeItem(StoryNodeItem parent, IXmlNode node) : this(Ioc.Default.GetRequiredService<ILogService>(), parent, node)
{
}

#endregion

public void Delete(StoryViewType storyView)
public void Delete(StoryViewType storyView)
{
_logger.Log(LogLevel.Trace, $"Starting to delete element {Name} ({Uuid}) from {storyView}");
//Sanity check
Expand Down
27 changes: 27 additions & 0 deletions StoryCADTests/NodeItemTests.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
using CommunityToolkit.Mvvm.DependencyInjection;
using Microsoft.VisualStudio.TestTools.UnitTesting;
using StoryCAD.Models;
using StoryCAD.ViewModels;

namespace StoryCADTests;

[TestClass]
class NodeItemTests
{
/// <summary>
/// Creates a new node and tries to delete it.
/// </summary>
[TestMethod]
public void TryDelete()
{
ShellViewModel Shell = Ioc.Default.GetRequiredService<ShellViewModel>();
StoryModel model = new();
ProblemModel Overview = new("Overview", model);
StoryNodeItem overview = new(null, Overview, null);
ProblemModel Problem = new("Test",model);
StoryNodeItem Prob = new(null, Problem, overview);

Shell.StoryModel = model;
Prob.Delete(StoryViewType.ExplorerView);
}
}

0 comments on commit 326fbcf

Please sign in to comment.