Correct Strings.toHexString Usage for Address Variables In Mock Modul…

…es (#387)
storyprotocol · Feb 26, 2025 · 440a1aa · 440a1aa
1 parent 4083406
commit 440a1aa
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/test/foundry/mocks/module/MockAllMetadataViewModule.sol b/test/foundry/mocks/module/MockAllMetadataViewModule.sol
@@ -52,7 +52,7 @@ contract MockAllMetadataViewModule is BaseModule, IViewModule {
             /* solhint-disable */
             abi.encodePacked(
                 '{"name": "IP Asset #',
-                Strings.toHexString(ipId),
+                Strings.toHexString(uint160(ipId)),
                 '", "description": "',
                 description(ipId),
                 '", "attributes": ['
@@ -70,7 +70,7 @@ contract MockAllMetadataViewModule is BaseModule, IViewModule {
                 ipType(ipId),
                 '"},'
                 '{"trait_type": "Owner", "value": "',
-                Strings.toHexString(owner(ipId)),
+                Strings.toHexString(uint160(owner(ipId))),
                 '"},'
                 '{"trait_type": "Registration Date", "value": "',
                 Strings.toString(registrationDate(ipId)),

diff --git a/test/foundry/mocks/module/MockCoreMetadataViewModule.sol b/test/foundry/mocks/module/MockCoreMetadataViewModule.sol
@@ -30,9 +30,9 @@ contract MockCoreMetadataViewModule is BaseModule, IViewModule {
             string.concat(
                 getName(ipId),
                 ", IP #",
-                Strings.toHexString(ipId),
+                Strings.toHexString(uint160(ipId)),
                 ", is currently owned by",
-                Strings.toHexString(owner(ipId)),
+                Strings.toHexString(uint160(owner(ipId))),
                 ". To learn more about this IP, visit ",
                 uri(ipId)
             );
@@ -55,7 +55,7 @@ contract MockCoreMetadataViewModule is BaseModule, IViewModule {
             /* solhint-disable */
             abi.encodePacked(
                 '{"name": "IP Asset #',
-                Strings.toHexString(ipId),
+                Strings.toHexString(uint160(ipId)),
                 '", "description": "',
                 description(ipId),
                 '", "attributes": ['
@@ -70,7 +70,7 @@ contract MockCoreMetadataViewModule is BaseModule, IViewModule {
                 getName(ipId),
                 '"},'
                 '{"trait_type": "Owner", "value": "',
-                Strings.toHexString(owner(ipId)),
+                Strings.toHexString(uint160(owner(ipId))),
                 '"},'
                 '{"trait_type": "Registration Date", "value": "',
                 Strings.toString(registrationDate(ipId)),