Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect variable names and code comments errors #380

Merged
merged 9 commits into from
Feb 9, 2025
Merged

Fix incorrect variable names and code comments errors #380

merged 9 commits into from
Feb 9, 2025

Conversation

offensif
Copy link

@offensif offensif commented Jan 11, 2025 •
edited
Loading

Description

Updated Variable Names:

From: commericialUseLicenseId

To: commercialUseLicenseId

From: nonCommericialLicenseId

To: nonCommercialLicenseId

Test Plan

Example:

    1. Use different test accounts for login tests, including correct user names and passwords, and incorrect user names and passwords.
    1. ...

Related Issue

Closes #381

Notes

  • Example: Links and navigation need to be added to the front-end interface

@offensif offensif changed the title Fix errors in variable names and code comments Fix incorrect variable names and code comments errors Jan 11, 2025
@kingster-will kingster-will merged commit ee30963 into storyprotocol:main Feb 9, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kingster-will kingster-will kingster-will approved these changes

@Spablob Spablob Awaiting requested review from Spablob Spablob is a code owner

@LeoHChen LeoHChen Awaiting requested review from LeoHChen LeoHChen is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Errors in Variable Names
2 participants
@offensif @kingster-will