Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix spelling issues #404

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+4 −4
Open

fix spelling issues #404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a21b784
Update IPILicenseTemplate.sol
sky-coderay Feb 10, 2025
9b2ba12
Update IIPAccount.sol
sky-coderay Feb 10, 2025
33dffc3
Update LicensingModule.sol
sky-coderay Feb 10, 2025
da7e92c
Update IPAccountImpl.sol
sky-coderay Feb 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion contracts/IPAccountImpl.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ contract IPAccountImpl is ERC6551, IPAccountStorage, IIPAccount {

/// @dev Override Solady 6551 _isValidSigner function.
/// @param signer The signer to check
/// @param extraData The extra data to check against, it should bethe address of the recipient for IPAccount
/// @param extraData The extra data to check against, it should be the address of the recipient for IPAccount
/// @param context The context for validating the signer
/// @return bool is true if the signer is valid, false otherwise
function _isValidSigner(
Expand Down
2 changes: 1 addition & 1 deletion contracts/interfaces/IIPAccount.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import { IIPAccountStorage } from "./IIPAccountStorage.sol";
/// like ownership of other NFTs such as license NFT or Royalty NFT.
/// IPAccount can interact with modules by making calls as a normal transaction sender.
/// This allows for seamless operations on the state and data of IP.
/// IPAccount is core identity for all actions.
/// IPAccount is the core identity for all actions.
interface IIPAccount is IIPAccountStorage {
/// @notice Emitted when a transaction is executed.
/// @param to The recipient of the transaction.
Expand Down
2 changes: 1 addition & 1 deletion contracts/interfaces/modules/licensing/IPILicenseTemplate.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import { ILicenseTemplate } from "../../../interfaces/modules/licensing/ILicense
/// @param commercialUse Indicates whether the work can be used commercially or not.
/// @param commercialAttribution whether attribution is required when reproducing the work commercially or not.
/// @param commercializerChecker commercializers that are allowed to commercially exploit the work. If zero address,
/// then no restrictions is enforced.
/// then no restrictions are enforced.
/// @param commercializerCheckerData The data to be passed to the commercializer checker contract.
/// @param commercialRevShare Percentage of revenue that must be shared with the licensor.
/// @param commercialRevCeiling The maximum revenue that can be generated from the commercial use of the work.
Expand Down
2 changes: 1 addition & 1 deletion contracts/modules/licensing/LicensingModule.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -861,7 +861,7 @@ contract LicensingModule is
if (oldLicensingConfig.licensingHook != licensingConfig.licensingHook) {
revert Errors.LicensingModule__GroupIpCannotChangeLicensingHook(groupId);
}
// check hood data are the same
// check hook data are the same
if (
oldLicensingConfig.hookData.length != licensingConfig.hookData.length ||
keccak256(oldLicensingConfig.hookData) != keccak256(licensingConfig.hookData)
Expand Down