Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Nonce State of IPAsset on Asset Changes and Disable ERC 1271 Signature Support #408

Merged
merged 2 commits into from
Feb 23, 2025

Conversation

kingster-will
Copy link
Collaborator

Description

This PR updates the state of an IPAsset whenever assets associated with the IPAsset, such as license terms, have been changed. Additionally, it disables support for ERC 1271 signatures to enhance security.

Key Changes

  • State Update: Added logic to update the state of an IPAsset when associated assets are modified.
  • Disable ERC 1271 Signature Support: Removed support for ERC 1271 signatures in the IPAccount contract.

Copy link
Member

@sebsadface sebsadface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LicensingModule slightly exceeds the contract size limit, otherwise LGTM
Screenshot 2025-02-22 at 18 19 24

@kingster-will kingster-will merged commit 710c74e into storyprotocol:main Feb 23, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants