Fix Typos and Improve Comments Across Multiple Files #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Himess
requested review from
kingster-will,
sebsadface,
Spablob and
LeoHChen
as code owners
sebsadface
approved these changes
Jan 24, 2025
|
Hi, I noticed that the PR has been approved but not yet merged. Is there anything else needed from my side to proceed with merging? Let me know if there are any additional steps required. Thank you! |
|
Hi @sebsadface , the pull request is approved and has no conflicts. However, one workflow is awaiting approval. Could you please review and approve it when you have a chance? Thanks in advance! |
Approved! |
sebsadface
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes typos and improves comments across several files in the protocol-periphery-v1 repository. Below are the details of the changes:
1-IOrgStoryNFTFactory.sol:
Corrected "a OrgStoryNFT" to "an OrgStoryNFT".
Fixed "signautre" to "signature".
Corrected "dployed" to "deployed".
Fixed "orgnization" to "organization".
2-IStoryBadgeNFT.sol:
Fixed "signautre" to "signature".
3-Errors.sol:
Corrected "exceed" to "exceeds".
4-MetadataHelper.sol:
Removed duplicate comment for the metadata function.
5-PermissionHelper.sol:
Corrected "mutiple" to "multiple".
6-CachableNFT.sol:
Updated a comment for better clarity:
From: "Mints NFTs to the cache."
To: "Mints NFTs and adds them to the cache."
7-OrgStoryNFTFactory.sol:
Fixed "signautre" to "signature".
Corrected "dployed" to "deployed" in two locations.
8-StoryBadgeNFT.sol:
Fixed "signautre" to "signature".
9-SPGNFT.sol:
Corrected "SPGNFTSotrage" to "SPGNFTStorage".
These changes enhance code readability and accuracy without modifying the logic or functionality of the contracts.