fix: prevent unintended license disablement during royalty vault deployment #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebsadface
requested review from
kingster-will,
Spablob and
LeoHChen
as code owners
sebsadface
force-pushed
the
fix/licenseCollision
branch
from
f0378fc to
35fd82a
Compare
sebsadface
changed the title
kingster-will
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enhances the license handling logic in the royalty vault deployment workflow by modifying the
_deployRoyaltyVaultfunction to first check if license terms are already attached to an IP before attempting to attach them.The update prevents unnecessary license disabling during royalty vault deployment by only disabling temporary licenses when they weren't previously attached. This improvement is validated through a new test case
test_RoyaltyTokenDistributionWorkflows_deployRoyaltyVault_LicenseShouldNotBeDisabledthat verifies licenses are not incorrectly disabled. Additionally, the PR includes a update from LAP (Liquid Absolute Percentage) to LRP (Liquid Relative Percentage) as the default royalty policy to be used inRoyaltyTokenDistributionWorkflowsThis PR removes two backward compatibility functions from
RoyaltyTokenDistributionWorkflowsto make space for other changes.