Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add missing expectations in IpWidget test #111

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Himess
Copy link
Contributor

@Himess Himess commented Jan 19, 2025

This PR adds missing expect statements to the IpWidget test. Previously, the test only rendered the component without validating its behavior or output. This change ensures the component behaves as expected and aligns with the project's testing standards.

Why this change?

The test suite in related repositories follows a standard of including expect statements to validate functionality. This PR brings the IpWidget test in line with that standard by adding expectations to ensure its behavior is properly validated.

References:

  1. attachLicenseTerms Test (protocol-core-v1)
  2. Permission Test (protocol-core-v1)
  3. TotalLicenseTokenLimitHook Test (protocol-periphery-v1)

These references demonstrate similar standards of using expect statements for validation across different parts of the project. This PR ensures consistency in the testing approach.

Copy link

vercel bot commented Jan 19, 2025

@Himess is attempting to deploy a commit to the Story Protocol Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant