Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract Hash Calculation Logic into a Separate Function #8

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MelodyFish
Copy link

Description

This PR extracts the repetitive hash calculation logic into a separate calculateHash function. The original hash calculation logic was duplicated in multiple places, and by extracting it, we improved code reusability and maintainability.

Changes:

Created the calculateHash function to compute the SHA-256 hash of a given input.
Replaced the duplicated hash calculation logic with calls to the new calculateHash function.

Impact:

Improved code maintainability by reducing redundancy.
The existing functionality remains unchanged, and the hash calculation logic is consistent.

Code Changes:

import { createHash } from 'crypto'

/**
 * Calculates the SHA-256 hash of the given data
 * 
 * @param {any} data - The data to hash, can be of any type.
 * @returns {string} The resulting hash value (hexadecimal string)
 */
function calculateHash(data: any): string {
    return createHash('sha256').update(JSON.stringify(data)).digest('hex')
}

const main = async function () {
    // Other code

    // Use the new calculateHash function
    const ipHash = calculateHash(ipMetadata)
    const nftHash = calculateHash(nftMetadata)

    // Other code
}

Notes:

This change does not affect the functionality of the code, and the logic remains the same.
The hash calculation logic is now more concise and reusable.

@loveyou30692
Copy link

This is the optimized version of the #calculateHash function.

import { createHash } from 'crypto';

/**

  • Calculates the SHA-256 hash of the given data

  • @param {any} data - The data to hash, can be of any type.

  • @returns {string} The resulting hash value (hexadecimal string)
    */
    function calculateHash(data: any): string {
    // Check for null or undefined data
    if (data === null || data === undefined) {
    throw new Error('Invalid data: data cannot be null or undefined');
    }

    // Handle cases where data cannot be serialized to JSON
    let jsonData: string;
    try {
    jsonData = JSON.stringify(data);
    } catch (error) {
    throw new Error('Invalid data: data cannot be converted to JSON string');
    }

    // Return the SHA-256 hash value
    return createHash('sha256').update(jsonData).digest('hex');
    }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants