Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add subdomain/hostname to pods created #360

Merged

Conversation

PFC-developer
Copy link
Contributor

This PR adds hostname & subdomain to pods on creation (similar to how stateful sets do).
This is needed for a headless service to have podname.servicename... DNS resolution (instead of just servicename).
ala
`
root@harpoon-horcrux-1:/# host harpoon-0.harpoon
harpoon-0.harpoon.cosmos.svc.cluster.local has address 10.0.9.240

root@harpoon-horcrux-1:/# host harpoon-1.harpoon
harpoon-1.harpoon.cosmos.svc.cluster.local has address 10.0.7.151

root@harpoon-horcrux-1:/# host harpoon-2.harpoon
harpoon-2.harpoon.cosmos.svc.cluster.local has address 10.0.8.192

root@harpoon-horcrux-1:/# host harpoon
harpoon.cosmos.svc.cluster.local has address 10.0.7.151
harpoon.cosmos.svc.cluster.local has address 10.0.9.240
harpoon.cosmos.svc.cluster.local has address 10.0.8.192
`
before this patch only the last 'DNS' lookup would work.
I don't believe it has any negative effects

Copy link
Contributor

@DavidNix DavidNix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you.

All changes require unit test coverage before merge. See CONTRIBUTING.md. Please look at pod_builder_test.go and add tests there.

internal/fullnode/build_pods.go Outdated Show resolved Hide resolved
@PFC-developer
Copy link
Contributor Author

moved logic to pod_builder and added test.

Copy link
Contributor Author

@PFC-developer PFC-developer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes applied

Copy link
Contributor

@DavidNix DavidNix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@DavidNix DavidNix merged commit f240661 into strangelove-ventures:main Sep 25, 2023
3 checks passed
@PFC-developer PFC-developer deleted the PR-hostname-servicename branch September 25, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants