Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dont require podspec image #378

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Dont require podspec image #378

merged 2 commits into from
Oct 26, 2023

Conversation

agouin
Copy link
Member

@agouin agouin commented Oct 25, 2023 •
edited
Loading

If spec.chain.versions is populated, then spec.podTemplate.image is not required

@agouin agouin requested a review from danbryan October 25, 2023 23:36
@agouin agouin marked this pull request as ready for review October 25, 2023 23:36
@agouin agouin merged commit c43035d into main Oct 26, 2023
4 checks passed
@agouin agouin deleted the andrew/dont_require_podspec_image branch October 26, 2023 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danbryan danbryan danbryan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agouin @danbryan