Skip to content
This repository has been archived by the owner on Aug 1, 2024. It is now read-only.

Add igp testing to cosmos e2e #87

Merged
merged 3 commits into from
Oct 26, 2023
Merged

Add igp testing to cosmos e2e #87

merged 3 commits into from
Oct 26, 2023

Conversation

misko9
Copy link
Contributor

@misko9 misko9 commented Oct 24, 2023

No description provided.

Copy link
Contributor

@KyleMoser KyleMoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Only thing I don't agree with is changing the payment from the Coin to the amount in the PayForGas events. IMO it was better as-is, it permanently records what payment was made (amount+denom). I could see a future where payments are supported in other denoms, or the payment denom changes for some reason.

That said, I don't feel that strongly about it, so I'm marking this approved. Just curious why that change is important.

@misko9
Copy link
Contributor Author

misko9 commented Oct 25, 2023

Looks good. Only thing I don't agree with is changing the payment from the Coin to the amount in the PayForGas events. IMO it was better as-is, it permanently records what payment was made (amount+denom). I could see a future where payments are supported in other denoms, or the payment denom changes for some reason.

That said, I don't feel that strongly about it, so I'm marking this approved. Just curious why that change is important.

Thanks @KyleMoser, I agree that it would be nice to be able to support multiple denoms, but hyperlane's agents don't support that yet. The relayer expects the payment event attribute to be an integer. We could add another event attribute for the denom, but it wouldn't be used.

@misko9
Copy link
Contributor Author

misko9 commented Oct 25, 2023

I will merge this in after the Val Announce PR since this is a stacked PR.

@misko9 misko9 changed the base branch from kamoser/val-announce to main October 26, 2023 20:30
@misko9 misko9 marked this pull request as ready for review October 26, 2023 20:30
@misko9 misko9 merged commit df93c7f into main Oct 26, 2023
2 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants