Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: MacOS strip debug info for proper runs #1286

Merged
merged 1 commit into from
Oct 30, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion local-interchain/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,11 @@ endif

# if env IGNORE_STATIC_LINK=true, then only set the main version in ldflags
# required so releasing the binary does not set the main directory incorrectly
ldflags = -X main.MakeFileInstallDirectory=$(CWD) -X main.Version=$(VERSION)
# -
# Stripping the debug info with -s -w fixes this so the binary
# is properly signed (MacOS sequoia + XCode 16 causes the binary to instantly die)
# ref: https://github.com/rollchains/spawn/issues/248
ldflags = -X main.MakeFileInstallDirectory=$(CWD) -X main.Version=$(VERSION) -s -w
ifeq ($(IGNORE_STATIC_LINK),true)
ldflags = -X main.Version=$(VERSION)
endif
Expand Down
Loading