Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(namada): Support Namada test #1296

Merged
merged 30 commits into from
Nov 12, 2024
Merged

feat(namada): Support Namada test #1296

merged 30 commits into from
Nov 12, 2024

Conversation

yito88
Copy link
Contributor

@yito88 yito88 commented Nov 6, 2024

To support Namada test,

  • Add Namada bootstrapping under chain/namada
  • Enable to specify an IP address for a node
    • It would be great if you had a better way to create docker network
  • Change Hermes config to set the chain type
  • Add the example test: examples/namada/namada_chain_test.go

@yito88 yito88 requested a review from a team as a code owner November 6, 2024 10:39
@yito88 yito88 requested a review from jtieri November 6, 2024 10:39
@vercel Vercel
Copy link

vercel bot commented Nov 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
interchaintest-docs ⬜️ Ignored (Inspect) Visit Preview Nov 12, 2024 2:26pm

Reecepbcups
Reecepbcups reviewed Nov 10, 2024
View reviewed changes
Copy link
Member

@Reecepbcups Reecepbcups left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sickkk, looks good! - few things then I can approve and merge :)

relayer/hermes/hermes_config.go Outdated Show resolved Hide resolved
chain/namada/namada_chain.go Outdated Show resolved Hide resolved
chain/namada/namada_chain.go Outdated Show resolved Hide resolved
chain/namada/namada_chain.go Show resolved Hide resolved
chain/namada/namada_chain.go Outdated Show resolved Hide resolved
chain/namada/namada_node.go Outdated Show resolved Hide resolved
configuredChains.yaml Outdated Show resolved Hide resolved
configuredChains.yaml Show resolved Hide resolved
@Reecepbcups Reecepbcups enabled auto-merge (squash) November 11, 2024 15:41
@yito88 yito88 mentioned this pull request Nov 11, 2024
Merged
@Reecepbcups
Copy link
Member

I think this PR is just blocked on getting a merge from latest main, not the link check fyi :)

@Reecepbcups Reecepbcups merged commit bab7af8 into strangelove-ventures:main Nov 12, 2024
19 of 20 checks passed
@yito88 yito88 mentioned this pull request Nov 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Reecepbcups Reecepbcups Reecepbcups approved these changes

@jtieri jtieri Awaiting requested review from jtieri jtieri is a code owner automatically assigned from strangelove-ventures/interchaintest-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yito88 @Reecepbcups