WIP - marionette updates part 1 #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rectly and works.
…cket context on a http request context to send commands to only one instead of broadcasting), added some debug logging
…generalized the 'host' and 'streak_key' info that is sent along with it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The server now validates the robot token
The server now requires that the viewer sending commands be logged in to Twitch
The server now correctly responds to the full sequence to fool the robot that it's connecting to a remo.tv compatible server
I had temporally added encryption to the web-sockets messaging but later removed it because it would require changes to the robot's controller code, and I though that for now requiring as few changes as possible to make it easier to change between using marionette and using remo.tv to be better. I can always add it back later.
This code (the original code also does this) currently does one thing incorrectly in my opinion, it can't send the command messages to just the robot, it will broadcast those to everyone who is connected to the web-socket, I couldn't thing a way to fix that, commit 004b072 was an attempt at that but it failed to work during testing, I did some other tests but tested those before making a commit and could not find anything that would work.
note: I have to fix some commit messages before this is merged