-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate translation-proxy-broke-pool
MG to Integration Test
#1415
base: main
Are you sure you want to change the base?
Migrate translation-proxy-broke-pool
MG to Integration Test
#1415
Conversation
e0adaa3
to
15a257b
Compare
15a257b
to
05bbfa5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1415 +/- ##
=======================================
Coverage 19.08% 19.08%
=======================================
Files 166 166
Lines 11066 11066
=======================================
Hits 2112 2112
Misses 8954 8954
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
close #1414
note: ideally, Sniffer should have a primitive to assert a connection was broken... but that is currently blocked by #1389 so we bypassed that by asserting that a port is free inside the test