Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow special characters in title #5253

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Disallow special characters in title #5253

merged 2 commits into from
Dec 13, 2024

Conversation

gettinToasty
Copy link
Contributor

Also adds missing translations and fixes capitalization

Also adds missing translations and fixes capitalization
@gettinToasty gettinToasty added bug P0 highest priority to merge from Asana labels Dec 11, 2024
Copy link

bundlemon bot commented Dec 11, 2024

BundleMon

Files updated (1)
Status Path Size Limits
renderer.(hash).js
7.02MB (+743B +0.01%) -
Unchanged files (3)
Status Path Size Limits
vendors~renderer.(hash).js
4.68MB -
updater.js
115.28KB -
guest-api.js
40.19KB -

Total files change +743B +0.01%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@marvinoffers
Copy link
Contributor

marvinoffers commented Dec 12, 2024

Thx for looking into this.
Preventing that special character gets added to the title - which is also great

The bigger issue is when the file-name itself includes the special character. So we need to make sure that it is not possible that files with special characters in the name get imported.

Just created a new ticket to implement a proper error state.

@gettinToasty gettinToasty merged commit 05fb6fa into master Dec 13, 2024
10 of 12 checks passed
@gettinToasty gettinToasty deleted the sb_hl_fixes branch December 13, 2024 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug P0 highest priority to merge from Asana
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants