Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Depth Bucket Sorting #152

Open
wants to merge 2 commits into
base: staging
Choose a base branch
from
Open

Fix Depth Bucket Sorting #152

wants to merge 2 commits into from

Conversation

kamyarinfinity
Copy link
Contributor

@kamyarinfinity kamyarinfinity commented May 31, 2019

This PR improves/fixes several aspects of sorting transparent objects:

  1. Fixes an issue where object insertion in the list was not happening correctly
  2. Adds code to avoid creating a loop in depth list and will also log this as an error
  3. Considers depth bias for all the cases when sorting
  4. Simplifies the sorting code to make it more readable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant