Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add remaining to base Stream type #109

Merged
merged 2 commits into from
Nov 27, 2023
Merged

Add remaining to base Stream type #109

merged 2 commits into from
Nov 27, 2023

Conversation

Yolley
Copy link
Collaborator

@Yolley Yolley commented Nov 27, 2023 •
edited
Loading

  • add remaining method because it's exposed via all implementation
  • remove unused formatDecodedStream as it's incompatible and long deprecated
  • deprotect abstract methods of BaseStreamClient because they aren't protected on implementations

@Yolley Yolley merged commit c226049 into master Nov 27, 2023
1 check passed
@Yolley Yolley deleted the oleg/feature/add_remaining_to_stream_type branch November 27, 2023 16:00
@github-actions GitHub Actions
Copy link

https://github.com/streamflow-finance/js-sdk/releases/tag/v5.6.5 is released 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukaStreamflow LukaStreamflow LukaStreamflow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yolley @LukaStreamflow