V7 #215
V7 #215
Conversation
* ESM Support (#179) * node imports * esm maybe * Prerelease publish v7 alpha * jest to vitest --------- Co-authored-by: Yolley <[email protected]>
* switch to bignubmer.js initial + rebase * fixes * fixes * public API and README update * bump to 7.0.0-alpa.2 * fix pre-commit * lerna version bump and import fixes * remove comments * remove more leftover comments
* separate bn conversion script from pre-commit * add eslint rule and improve script * fix missing .js extensions in exports and bump alpha version * more missing .js extensions and BigNumber fixes * replace npm with pnpm
* Staking SDK
Bump/7.0.0 alpha.7
bump 7.0.0-alpha.8
bump 7.0.0-alpha.9
…r-fetches Feat/update values for fetches
bump 7.0.0-alpha.11
* revert initial * small readme fix * another readme fix
| return rewardPoolProgram.account.rewardEntry.all(getFilters(criteria, REWARD_ENTRY_BYTE_OFFSETS)); | ||
| } | ||
|
|
||
| getFeeValueIfExists(target: string | PublicKey): Promise<FeeValue | null> { |
There was a problem hiding this comment.
Let's also expose fee config may be? So that we could fetch default fee, and may be some helper methods that just returns fee for a given wallet? (the same way as we check default fee for a partner wallet in StreamClient).
Example of config fetching https://github.com/streamflow-finance/streamflow-staking/blob/main/tests/test-fee-manager/update-fee-config.test.ts#L18
There was a problem hiding this comment.
some helper methods that just returns fee for a given wallet
this function does exactly it, doesn't it?
I see possibility to change this behavior and make it
fetchForWallet(pk) || fetchDefault(), do you mean a function that does fetch with default config fallback?
There was a problem hiding this comment.
updated,
put 3 apis for fee:
- getFee -> whitelisted or default
- getDefault
- getFeeForWallet nullable
- Extend distributor input typings
packages/stream/README.md
Outdated
There was a problem hiding this comment.
these changes to README can be reverted, looks like I missed it in reverting the BigNumber changes
The app is migrated in one of PRs, so it should be ok to release this version as the latest major