Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove scharp client from repo #29

Merged
merged 1 commit into from
Aug 7, 2020
Merged

Remove scharp client from repo #29

merged 1 commit into from
Aug 7, 2020

Conversation

wolfstudy
Copy link
Contributor

Signed-off-by: xiaolong.ran [email protected]

Remove scharp client from repo

@wolfstudy wolfstudy requested a review from a team as a code owner August 7, 2020 04:28
@wolfstudy wolfstudy requested review from jiazhai and sijie August 7, 2020 04:28
@wolfstudy wolfstudy self-assigned this Aug 7, 2020
jiazhai
jiazhai approved these changes Aug 7, 2020
View reviewed changes
Copy link
Contributor

@jiazhai jiazhai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure this un-do work is tracked by other issue.

@wolfstudy
Copy link
Contributor Author

make sure this un-do work is tracked by other issue.

Yes, the #22 will track this task

@wolfstudy wolfstudy merged commit 7ef3610 into master Aug 7, 2020
@wolfstudy wolfstudy deleted the xiaolong/remove-csharp branch August 7, 2020 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Huanli-Meng Huanli-Meng Huanli-Meng approved these changes

@jiazhai jiazhai jiazhai approved these changes

@sijie sijie Awaiting requested review from sijie

Assignees

@wolfstudy wolfstudy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wolfstudy @jiazhai @Huanli-Meng