Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear pooled connection after node health checks #557

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

merlimat
Copy link
Collaborator

When using Istio between coordinator and storage node, we should discard all the pooled connections in the coordinator, after a node is declared failed (and then it recovers).

The problem is that the gRPC client is not able to detect that TCP has failed, because of the Istio proxy. eg:

  • the istio is still setup to talk with the old pod
  • coordinator uses the pooled client and writes to a gRPC stream. There is no failure, even though the channel is not valid

In normal conditions, gRPC will process the TCP failure and open a new connection, though this does not work with Istio in between.

Modifications

Force to discard all the pooled gRPC clients for target node once we have successfully reconnected with the new pod.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant