Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getAllSchemas command #1601

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

calindima
Copy link

@calindima calindima commented Sep 24, 2024

I didn't create an issue but I can if that's necessary, otherwise I'll write the details in this PR.

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

We have a use case where we want to query the SchemaRegistry to retrieve a history of schema versions and observe schema evolution for topics with higher retention (e.g. infinite retention, >6mo retention etc.).

Modifications

Describe the modifications you've done.

The PR only contains additions such as:

  • Added a new file for getAllSchemas command which retrieves all schemas of a topic and pretty prints them
  • Added a helper method to pretty print the schema list
  • Added a call to register the new command
  • Added a test

I'm not completely sure if adding a new command was the way to go, so I'm open to suggestions for alternatives (e.g. as a flag to the get command)

Verifying this change

  • Make sure that the change passes the CI checks.

This change added tests and can be verified as follows:

  • Added a test to check the output of the new command

Documentation

Check the box below.

Need to update docs?

I'm actually not sure if there are any docs I should update, very open to feedback on this one.

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

Copy link

@calindima:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@github-actions github-actions bot added the doc-info-missing This pr needs to mark a document option in description label Sep 24, 2024
Comment on lines +25 to +26
replace github.com/apache/pulsar-client-go v0.13.0-candidate-1.0.20240813105849-ab042ae714d1 => ../pulsar-client-go

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll remove this and change the version once apache/pulsar-client-go#1289 is released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-info-missing This pr needs to mark a document option in description
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant