Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add IMDSv2 to AWS by default #134

Closed
wants to merge 2 commits into from
Closed

feat: Add IMDSv2 to AWS by default #134

wants to merge 2 commits into from

Conversation

mitch-hamm
Copy link

@mitch-hamm mitch-hamm commented Jun 4, 2024

Master Issue: #1197

Motivation

Enable IMDSv2 by default for AWS clusters

Modifications

Update the module to enable IMDSv2 at the node pool level

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

This change added tests and can be verified as follows:

  • Enabling on existing cluster to verify the BYOC env still functions

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    Default security upgrade that should be standard across all EKS

@mitch-hamm mitch-hamm requested a review from a team as a code owner June 4, 2024 17:02
Copy link
Contributor

github-actions bot commented Jun 4, 2024

@mitch-hamm:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@github-actions github-actions bot added the doc-info-missing This pr needs to mark a document option in description label Jun 4, 2024
@mitch-hamm mitch-hamm changed the title Add IMDSv2 to AWS by default feat: Add IMDSv2 to AWS by default Jun 4, 2024
@github-actions github-actions bot removed the doc-info-missing This pr needs to mark a document option in description label Jun 11, 2024
Copy link
Contributor

@mitch-hamm:Thanks for providing doc info!

@github-actions github-actions bot added the no-need-doc This pr does not need any document label Jun 11, 2024
@mitch-hamm
Copy link
Author

Closing as https://registry.terraform.io/modules/terraform-aws-modules/eks/aws/18.30.2/submodules/eks-managed-node-group?tab=inputs defaults to IMDSv2 by default. This should already be on for EKS node groups

@mitch-hamm mitch-hamm closed this Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-need-doc This pr does not need any document
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant