Disable persisted cache for API responses, add refresh button #1043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeEdgar
force-pushed
the
no-caching
branch
3 times, most recently
from
ee5bc34
to
55d4fde
Compare
MikeEdgar
force-pushed
the
no-caching
branch
from
55d4fde
to
c940570
Compare
|
@MikeEdgar this should be good to go now |
riccardo-forina
force-pushed
the
no-caching
branch
from
5eb360b
to
1826e6f
Compare
MikeEdgar
force-pushed
the
no-caching
branch
from
1826e6f
to
fcf25bb
Compare
MikeEdgar
changed the title
MikeEdgar
approved these changes
Sep 20, 2024
|
@riccardo-forina there are two playwright tests failing (both browsers) that look like they might be legitimate errors |
riccardo-forina
force-pushed
the
no-caching
branch
from
fcf25bb
to
1c194db
Compare
Signed-off-by: Michael Edgar <[email protected]>
riccardo-forina
force-pushed
the
no-caching
branch
from
1c194db
to
81c5311
Compare
riccardo-forina
force-pushed
the
no-caching
branch
from
81c5311
to
755b981
Compare
|
Well the test suite's been completely updated to reuse the navigation bits and the auth bits as well. It should be easier to grok and maintain, and should pass the checks |
|
yep! |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should disable any persisted cache for all API responses in the app.
It also adds a "Last updated" info on every page, in the header. The messages page will not show this, as the data refresh is handled by the table in the body.