Bump the patternfly group in /ui with 7 updates #994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
dependencies
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/ui/patternfly-be2d9dd4ed
branch
3 times, most recently
from
5b688ee
to
3b62596
Compare
|
@dependabot rebase |
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/ui/patternfly-be2d9dd4ed
branch
from
3b62596
to
fe8969d
Compare
MikeEdgar
force-pushed
the
dependabot/npm_and_yarn/ui/patternfly-be2d9dd4ed
branch
from
fe8969d
to
ef7f4cf
Compare
|
@riccardo-forina apparently a See patternfly/patternfly-react#10283 for the patternfly change that seems to cause the error. |
|
The storybook tests don't seem to be picking up the change for the added |
MikeEdgar
force-pushed
the
dependabot/npm_and_yarn/ui/patternfly-be2d9dd4ed
branch
from
a0e7a1b
to
c920b98
Compare
Even though the component works fine in the prod app, storybook does not provide an element in the DOM with id="root". We won't be able to update patternfly unless we can work around it or propose some other fix in patternfly instead of patternfly/patternfly-react#10283 |
|
@MikeEdgar, I also tried some workarounds but still storybook is not working for Dragdrop, I will discuss this issue in the Patternfly slack channel |
|
Have you tried adding the div like this? |
Bumps the patternfly group in /ui with 7 updates: | Package | From | To | | --- | --- | --- | | [@patternfly/patternfly](https://github.com/patternfly/patternfly) | `5.3.1` | `5.4.0` | | [@patternfly/react-charts](https://github.com/patternfly/patternfly-react) | `7.3.0` | `7.4.0` | | [@patternfly/react-core](https://github.com/patternfly/patternfly-react) | `5.3.4` | `5.4.0` | | [@patternfly/react-drag-drop](https://github.com/patternfly/patternfly-react) | `5.3.4` | `5.4.0` | | [@patternfly/react-icons](https://github.com/patternfly/patternfly-react) | `5.3.2` | `5.4.0` | | [@patternfly/react-table](https://github.com/patternfly/patternfly-react) | `5.3.4` | `5.4.0` | | [@patternfly/react-tokens](https://github.com/patternfly/patternfly-react) | `5.3.1` | `5.4.0` | Updates `@patternfly/patternfly` from 5.3.1 to 5.4.0 - [Release notes](https://github.com/patternfly/patternfly/releases) - [Changelog](https://github.com/patternfly/patternfly/blob/main/release.config.js) - [Commits](patternfly/patternfly@patch-v5.3.1...v5.4.0) Updates `@patternfly/react-charts` from 7.3.0 to 7.4.0 - [Release notes](https://github.com/patternfly/patternfly-react/releases) - [Commits](https://github.com/patternfly/patternfly-react/compare/@patternfly/[email protected]...@patternfly/[email protected]) Updates `@patternfly/react-core` from 5.3.4 to 5.4.0 - [Release notes](https://github.com/patternfly/patternfly-react/releases) - [Commits](https://github.com/patternfly/patternfly-react/compare/@patternfly/[email protected]...@patternfly/[email protected]) Updates `@patternfly/react-drag-drop` from 5.3.4 to 5.4.0 - [Release notes](https://github.com/patternfly/patternfly-react/releases) - [Commits](https://github.com/patternfly/patternfly-react/compare/@patternfly/[email protected]...@patternfly/[email protected]) Updates `@patternfly/react-icons` from 5.3.2 to 5.4.0 - [Release notes](https://github.com/patternfly/patternfly-react/releases) - [Commits](https://github.com/patternfly/patternfly-react/compare/@patternfly/[email protected]...@patternfly/[email protected]) Updates `@patternfly/react-table` from 5.3.4 to 5.4.0 - [Release notes](https://github.com/patternfly/patternfly-react/releases) - [Commits](https://github.com/patternfly/patternfly-react/compare/@patternfly/[email protected]...@patternfly/[email protected]) Updates `@patternfly/react-tokens` from 5.3.1 to 5.4.0 - [Release notes](https://github.com/patternfly/patternfly-react/releases) - [Commits](https://github.com/patternfly/patternfly-react/compare/@patternfly/[email protected]...@patternfly/[email protected]) --- updated-dependencies: - dependency-name: "@patternfly/patternfly" dependency-type: direct:production update-type: version-update:semver-minor dependency-group: patternfly - dependency-name: "@patternfly/react-charts" dependency-type: direct:production update-type: version-update:semver-minor dependency-group: patternfly - dependency-name: "@patternfly/react-core" dependency-type: direct:production update-type: version-update:semver-minor dependency-group: patternfly - dependency-name: "@patternfly/react-drag-drop" dependency-type: direct:production update-type: version-update:semver-minor dependency-group: patternfly - dependency-name: "@patternfly/react-icons" dependency-type: direct:production update-type: version-update:semver-minor dependency-group: patternfly - dependency-name: "@patternfly/react-table" dependency-type: direct:production update-type: version-update:semver-minor dependency-group: patternfly - dependency-name: "@patternfly/react-tokens" dependency-type: direct:production update-type: version-update:semver-minor dependency-group: patternfly ... Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Michael Edgar <[email protected]>
Signed-off-by: Michael Edgar <[email protected]>
Nope, I'll try that now. |
Signed-off-by: Michael Edgar <[email protected]>
MikeEdgar
force-pushed
the
dependabot/npm_and_yarn/ui/patternfly-be2d9dd4ed
branch
from
c920b98
to
7151416
Compare
|
MikeEdgar
approved these changes
Sep 3, 2024
|
It looks like that did the trick :) |
MikeEdgar
deleted the
dependabot/npm_and_yarn/ui/patternfly-be2d9dd4ed
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps the patternfly group in /ui with 7 updates:
5.3.15.4.07.3.07.4.05.3.45.4.05.3.45.4.05.3.25.4.05.3.45.4.05.3.15.4.0Updates
@patternfly/patternflyfrom 5.3.1 to 5.4.0Release notes
Sourced from
@patternfly/patternfly's releases.... (truncated)
Commits
f75001aUpdate issue templatesa9e2a7aUpdate issue templatesc0c2559Update and rename PF6_alpha_bug_request.md to PF6_beta_bug_request.md (#6935)fec6266chore(deps): update dependency@patternfly/documentation-frameworkto v5.16.1...1550c08chore(deps): update dependency@patternfly/documentation-frameworkto v5.16.1...ca9b9e6fix(InlineEdit): updated example to match React (#6877)d5ee3d9chore(build): corepack use [email protected] (#6872)50182bechore(deps): update dependency@patternfly/react-code-editorto v5.3.4 (#6859)aad6f30fix(form): support label addl info in horizontal form (#6853)baa5f63chore(deps): update dependency@patternfly/react-tableto v5.3.4 (#6861)Updates
@patternfly/react-chartsfrom 7.3.0 to 7.4.0Commits
3ef073achore(release): releasing packages [ci skip]7a25febchore: Update promote.sh to promote to npm.494143dchore: Update promote.sh with dry run5836008Revert "chore(release): Update promote.sh"5937183chore(release): Update promote.sh701ccd9Revert "chore(release): releasing packages [ci skip]"48c08cbchore(release): releasing packages [ci skip]a76ba5echore(release): releasing packages [ci skip]279c54ffix(Table): remove blank scope in empty deprecated table headers (#10875)7b64b05Update issue templatesUpdates
@patternfly/react-corefrom 5.3.4 to 5.4.0Commits
3ef073achore(release): releasing packages [ci skip]7a25febchore: Update promote.sh to promote to npm.494143dchore: Update promote.sh with dry run5836008Revert "chore(release): Update promote.sh"5937183chore(release): Update promote.sh701ccd9Revert "chore(release): releasing packages [ci skip]"48c08cbchore(release): releasing packages [ci skip]a76ba5echore(release): releasing packages [ci skip]279c54ffix(Table): remove blank scope in empty deprecated table headers (#10875)7b64b05Update issue templatesUpdates
@patternfly/react-drag-dropfrom 5.3.4 to 5.4.0Release notes
Sourced from
@patternfly/react-drag-drop's releases.... (truncated)
Commits
3ef073achore(release): releasing packages [ci skip]7a25febchore: Update promote.sh to promote to npm.494143dchore: Update promote.sh with dry run5836008Revert "chore(release): Update promote.sh"5937183chore(release): Update promote.sh701ccd9Revert "chore(release): releasing packages [ci skip]"48c08cbchore(release): releasing packages [ci skip]a76ba5echore(release): releasing packages [ci skip]279c54ffix(Table): remove blank scope in empty deprecated table headers (#10875)7b64b05Update issue templatesUpdates
@patternfly/react-iconsfrom 5.3.2 to 5.4.0Commits
3ef073achore(release): releasing packages [ci skip]7a25febchore: Update promote.sh to promote to npm.494143dchore: Update promote.sh with dry run5836008Revert "chore(release): Update promote.sh"5937183chore(release): Update promote.sh701ccd9Revert "chore(release): releasing packages [ci skip]"48c08cbchore(release): releasing packages [ci skip]a76ba5echore(release): releasing packages [ci skip]279c54ffix(Table): remove blank scope in empty deprecated table headers (#10875)7b64b05Update issue templatesUpdates
@patternfly/react-tablefrom 5.3.4 to 5.4.0Commits
3ef073achore(release): releasing packages [ci skip]7a25febchore: Update promote.sh to promote to npm.494143dchore: Update promote.sh with dry run5836008Revert "chore(release): Update promote.sh"5937183chore(release): Update promote.sh701ccd9Revert "chore(release): releasing packages [ci skip]"48c08cbchore(release): releasing packages [ci skip]a76ba5echore(release): releasing packages [ci skip]279c54ffix(Table): remove blank scope in empty deprecated table headers (#10875)7b64b05Update issue templatesUpdates
@patternfly/react-tokensfrom 5.3.1 to 5.4.0Commits
3ef073achore(release): releasing packages [ci skip]7a25febchore: Update promote.sh to promote to npm.494143dchore: Update promote.sh with dry run5836008Revert "chore(release): Update promote.sh"5937183chore(release): Update promote.sh701ccd9Revert "chore(release): releasing packages [ci skip]"48c08cbchore(release): releasing packages [ci skip]a76ba5echore(release): releasing packages [ci skip]279c54ffix(Table): remove blank scope in empty deprecated table headers (#10875)7b64b05Update issue templatesDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions