web: add a simple command palette #7314
Draft
+821
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ojoanalogo
reviewed
Jan 13, 2025
| (selected) => (selected + 1) % filteredCommands.length | ||
| ); | ||
| } | ||
| if (e.key === "ArrowUp") { |
There was a problem hiding this comment.
I suggest you keep these keyboard keys as an enum in a separate file to avoid using "magic strings".
There was a problem hiding this comment.
Sounds good, maybe we can take this up in a separate PR
Signed-off-by: 01zulfi <[email protected]>
Signed-off-by: 01zulfi <[email protected]>
Signed-off-by: 01zulfi <[email protected]>
Signed-off-by: 01zulfi <[email protected]>
Signed-off-by: 01zulfi <[email protected]>
01zulfi
force-pushed
the
web/command-palette
branch
from
c3946b4 to
7505704
Compare
Signed-off-by: 01zulfi <[email protected]>
Signed-off-by: 01zulfi <[email protected]>
thecodrr
requested changes
Jan 27, 2025
apps/web/src/dialogs/command-palette/command-palette-dialog.tsx
Outdated
Show resolved
Hide resolved
Comment on lines
270
to
282
| function getMatchingIndices(text: string, query: string) { | ||
| const indices: number[] = []; | ||
| const set = new Set(query.toLowerCase()); | ||
| const lowerText = text.toLowerCase(); | ||
|
|
||
| for (let i = 0; i < lowerText.length; i++) { | ||
| if (set.has(lowerText[i])) { | ||
| indices.push(i); | ||
| } | ||
| } | ||
|
|
||
| return indices; | ||
| } |
There was a problem hiding this comment.
This is super funky looking and I am not sure it does what we want it too. It'll just highlight all the matching characters which isn't strictly what we want. How about using surround function from fuzzyjs?
Signed-off-by: 01zulfi <[email protected]>
Signed-off-by: 01zulfi <[email protected]>
01zulfi
commented
Jan 27, 2025
Comment on lines
+261
to
+269
| const result = queryClean.length > 0 ? match(queryClean, text) : false; | ||
|
|
||
| return ( | ||
| <span | ||
| dangerouslySetInnerHTML={{ | ||
| __html: | ||
| result && result.match | ||
| ? surround(text, { | ||
| result: result, |
There was a problem hiding this comment.
I have to use fuzzyjs's match again here to be able to use surround. Is this fine, or do you think we should refactor so that the lookup in core returns the object that surround expects?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: 01zulfi [email protected]