-
-
Notifications
You must be signed in to change notification settings - Fork 953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: README.md update - Consistency updates #2473
base: master
Are you sure you want to change the base?
Conversation
I still need to do a few tests but we can start the conversation. The main highlight is to bring clarity and direct game devs vs contributors where they should go. It might look reperative but it depends, where you land. So any of the pages mentioned below will direct/redirect you further. Get started with StrideThe Get started pages also adds some intro https://stride-doc-staging.azurewebsites.net/latest/en/manual/get-started/index.html Install StrideAnd so do Install page https://stride-doc-staging.azurewebsites.net/latest/en/manual/get-started/install-stride.html |
Additionally, this PR brings README.md consistency across: |
I think we can do without the table of contents, our readme isn't that long |
The purpose of Table of Contents is really just a shortcut link to take you down, so you don't have to scroll. The title itself could be removed. You can check how it works here: https://github.com/VaclavElias/stride/tree/readme-update Earn Money, is a shortuct, which takes you down in the page, where is the old content. |
3. **[Visual Studio 2022](https://visualstudio.microsoft.com/downloads/)** (the Community edition is free) with the following workloads: | ||
- **.NET desktop development** with **.NET Framework 4.7.2 targeting pack** (should be enabled by default) | ||
- **Desktop development with C++** with: | ||
- **Windows 11 SDK (10.0.22621.0)** or a later version (should be enabled by default) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Win 11 SDK ? Are you sure about this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
100%, tested on clean Win 11. It is selected by default actually by the installer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We had there before Windows 10 SDK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this requirement applies to UWP, so it's not a big deal. I wonder if version is also correct🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I would keep README.md file as short as possible, so I would also concider removing TOC and shortify " Stride Documentation Landscape" paragraf maybe(?) |
Otherwise nice work |
- Navigate to the `/build` directory in the command prompt. | ||
- Run: | ||
```bash | ||
msbuild /t:Restore Stride.sln |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess both commands can be combined as well
msbuild /t:Restore Stride.sln | |
msbuild /t:Restore Stride.sln; compile.bat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have to test this part also on clean Win 11. Once tested and working, I will take it 🙂
Have you tried this link? https://github.com/VaclavElias/stride/tree/readme-update The purpose of a Table of Contents is to help you quickly navigate to a section without scrolling. This becomes a time saver when you repeatedly access the same part of the page. If you only visit the README once a year, it might be unnecessary. But if you're there frequently, it definitely helps. If you and the team have considered this perspective and still see no benefit, then sure, it can be removed. 🙂 Regarding the Stride Documentation Landscape, there's also a strategic reason for its inclusion across all repositories: Docs, Website, and Toolkit. We face a challenge with users finding the material we already have. So, no matter which repository you land on, if you bother to scroll to the bottom, all the important links are available at a glance. This allows users to navigate anywhere without needing to go to Discord to ask where things are. This feature is a time saver for us, as we don't have to repeatedly direct people to certain parts of our documentation landscape. Ideally, users will find what they need themselves, allowing us to save our time for PRs and other tasks. 🤣 Also, it's intentionally placed at the bottom so it doesn’t clutter the top of the README. By the way, once the Docs Contributors https://doc.stride3d.net/latest/en/contributors/engine/index.html section is sorted and reviewed, we can move the entire Building from Source section to our docs. This way, we won’t have to maintain and update it in two places. |
This pull request updates the
README.md
file to improve its structure, readability, and navigation. The changes include adding hyperlinks, reorganizing sections, and enhancing the overall content to provide a better user experience.Enhancements to
README.md
:Navigation and Structure:
Content Updates:
Hyperlinks and References:
Visual Enhancements:
These changes aim to make the
README.md
more user-friendly and informative, helping new users get started quickly and existing users find the information they need more efficiently.# PR DetailsThis PR brings consistency across Stride repos.
You can see the updated version here: https://github.com/VaclavElias/stride/tree/readme-update
Related Issue
#2265
Types of changes
Checklist