Fix handling of advertised listeners for controller nodes #9340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rimzi#9336 Signed-off-by: Jakub Scholz <[email protected]>
|
/azp run kraft-regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ppatierno
reviewed
Nov 10, 2023
...er-operator/src/main/java/io/strimzi/operator/cluster/operator/assembly/KafkaReconciler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Jakub Scholz <[email protected]>
scholzj
deleted the
fix-advertsied-addresses-handling-of-controller-nodes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Currently, the operator tries to get the advertised listener hostnames / ports for the controller nodes in KRaft mode and use them as an annotation. This is wrong as the controller nodes do not really have any advertised listeenrs. By coincidence, the
type: internallisteners were geenrating the names so everything seemed to work. But when you try to deploy a Kafka cluster without such listener, it starts throwing NPEs.This PR cleans-up the handling to use the advertised hostnames / ports only for broker nodes for the annotations to fix this.
This should fix #9336.
Checklist