Chain Errors #715
Open
Chain Errors #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & motivation
Currently Stripe is swallowing the underlying errors and returning a generic error:
stripe-js/src/shared.ts
Line 71 in 085deba
This can make it difficult to debug since every error gets reported the same way.
Since every JavaScript runtime now supports chaining errors, we could also chain errors here.
Testing & documentation
Unfortunately this change requires at least TypeScript 4.8 (change) (change) I was forced to upgrade it to at least that in order to get the tests to pass.