This repository has been archived by the owner on Jan 10, 2024. It is now read-only.
Link element name instead of element #72
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When deploymentNode has an url, we were adding hyperlink to the node itself. This adds the link on the element name instead.
ezr-ondrej
commented
Sep 7, 2023
| @@ -351,7 +351,7 @@ protected void writeElement(ModelView view, Element element, IndentingWriter wri | |||
| shape = plantUMLShapeOf(view, elementInstance.getElement()); | |||
|
|
|||
| if (StringUtils.isNullOrEmpty(url)) { | |||
| url = element.getUrl(); | |||
| url = elementInstance.getUrl(); | |||
There was a problem hiding this comment.
I wonder if this was supposed to be the instance Url - just noticed this when going through the code.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all!
Very nice tool! :) I'm trying it out, but one thing I've noticed when using hyperlinks in plantuml export is, that the link is on the component.
I'm not sure if that was by purpose (to keep the formating of the component), tho in my use case I'd really want the link to be visible to the user.
Let me know what you think :)
I can of course use some post processing if this was intentional :)