Validate config using JSON schema #2123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simondel
reviewed
Apr 4, 2020
nicojs
force-pushed
the
feat/validate-config-using-json-schema
branch
from
70e95bf to
2fcf055
Compare
|
Note: Mutation testing report can be found here: |
nicojs
force-pushed
the
feat/validate-config-using-json-schema
branch
from
2fcf055 to
627d2f7
Compare
|
I just rebased on master, please rebase and merge instead of squash merge, if you're ready. |
|
@simondel I've found this package and tested it out: https://github.com/atlassian/better-ajv-errors It actually works great. Although it won't filter the errors, so it would only be a replacement for Some examples:
Also, it will not represent the actual code of your Stryker options are written in plain JS format rather than your JSON format. |
|
I think I'm falling in love with better-ajv-errors 😍 |
|
I've opened an issue to move all the ajv error filtering logic to better-ajv-errors, let's see what they think about it: |
simondel
approved these changes
Apr 12, 2020
* Deprecate `Config`, use `StrykerOptions` instead (no `set` method) * Deprecate `ConfigEditor`, use `OptionsEditor` instead
Use the declarative nature of JSON schema to make implementation more DRY and maintainable. * Use [ajv](https://github.com/epoberezkin/ajv) to validate StrykerOptions against the schema * Use ajv to fill in the default values
Introduce the `ConfigError`. If that is thrown, no stacktrace will be shown
Remove es5 workarounds around `Error`, so `err instanceof StrykerError` works
nicojs
force-pushed
the
feat/validate-config-using-json-schema
branch
from
627d2f7 to
ea6a895
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge request is far too big! (sorry 🙄)
A number of improvements:
Configin favor ofStrykerOptionsConfiganinterfacenow, for the time being, to be removed in next major versionStrykerOptionsJSON schema from the APIStrykerOptionsusing JSON schemafilterEmptyin favor ofnotEmptynoopLoggerto utils (used in 3 places now)instanceof StrykerErrorworks.Please don't squash merge (rebase and merge is fine), so the changelog will contain all these things.