-
-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Abstract getStyleRule #216
base: main
Are you sure you want to change the base?
Conversation
Thank you very much for working on this, @joebourne. What about |
No problem, and thanks for reviewing @MicheleBertoli. I've fixed up the import now. |
Hey @joebourne, thank you very much for your update. |
Ah yes sorry @MicheleBertoli, the import is now coming from a new |
Hi @MicheleBertoli, can I get an update on this please? Is there anything else you want fixing up? |
@joebourne if you wouldn't mind getting this fixed up against the new 7.x beta code I'd be interested to include the new functionality in 7.0 final :) |
…ponents into abstract-getStyleRule
@probablyup great! I've just fixed it up if you could take another look. Thanks. |
This PR attempts to fix #117.
@MicheleBertoli I was not sure how you would want this utility to be exported. To stop it being run when calling
import 'jest-styled-components'
we could export it from its own file i.e.import getStyleRule from 'jest-styled-components/getStyleRule'
, but it's less intuitive for users.Let me know what you think. Thanks.