Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added topic constructors to day 12 #153

Merged
merged 3 commits into from
Jun 12, 2024

Conversation

pankhuri92
Copy link
Contributor

@pankhuri92 pankhuri92 commented Jun 3, 2024

Fix #96
There are 4 subtopics to 'Constructors' that I have added.

Screenshot 2024-06-04 201117
Screenshot 2024-06-04 201159
Screenshot 2024-06-04 201219
Screenshot 2024-06-04 201230
Screenshot 2024-06-04 201253

@subhadipbhowmik
Copy link
Owner

Do not just copy and paste files. We are set on some rules. We have Till Day 11 Curricullam. We Will Extend After Some Days. Work On only one file at a time.

@pankhuri92
Copy link
Contributor Author

I had framed the content after going through materials but I reviewed it again since u asked. And I can add the topic of constructors to day 07 after functions if you permit.

Screenshot 2024-06-04 201916

@pankhuri92
Copy link
Contributor Author

Since putting all of the content in one file made it look monotonous, I split it into subparts - 'Introduction', 'Types', etc. Hence there are multiple files committed.

@pankhuri92
Copy link
Contributor Author

Kindly review.

@pankhuri92
Copy link
Contributor Author

@subhadipbhowmik please review my pr. It's been over a week.

@subhadipbhowmik
Copy link
Owner

Work On only one file at a time.

Work On only one file at a time.

@pankhuri92
Copy link
Contributor Author

@subhadipbhowmik Can you please elaborate on your point. Do you want me to put all the content under just one file? I can do that but then it won't be well categorised like this. It will become a single page of this long content.

@subhadipbhowmik subhadipbhowmik merged commit 0b42f8b into subhadipbhowmik:main Jun 12, 2024
Copy link

🎉 Your pull request has been successfully merged! 🎉 Thank you for your contribution to our project. Your efforts are greatly appreciated. Keep up the fantastic work! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add day 10 content
2 participants