[C#] rework tuple scopes to match Python #2969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrappen
reviewed
Aug 18, 2021
|
I assume you could also move to |
|
Moving to syntax version 2 would be a separate step/PR, IMHO. This is just a follow up to tidy meta scopes of sequences. |
deathaxe
reviewed
Aug 18, 2021
also don't include prototype as lookahead char is immediately consumed
deathaxe
reviewed
Aug 18, 2021
deathaxe
reviewed
Aug 18, 2021
deathaxe
previously approved these changes
Aug 18, 2021
deathaxe
approved these changes
Aug 19, 2021
UltraInstinct05
approved these changes
Aug 23, 2021
jfcherng
approved these changes
Aug 23, 2021
mitranim
pushed a commit
to mitranim/Packages
that referenced
this pull request
Mar 25, 2022
* [C#] rework tuple scopes to match Python * [C#] use named context for tuple or group branches also don't include prototype as lookahead char is immediately consumed * [C#] remove unnecessary capture group
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the meta and punctuation scopes used for tuples in the C# syntax to match the Python syntax definition - from
meta.group.tuple punctuation.section.group.begintometa.sequence.tuple punctuation.section.sequence.beginetc.Suggested in #2838 (comment)