[Haskell] Fix data constructor definitions #3241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to Haskell's wording ... - type constructors are scoped `support.type`, `storage.type` Type constructors without parameters are called "type". - data constructors are scoped `support.constant`, `constant.other` Data constructors without parameters are called "constant". Data constructors denote first class values. As such they can be assigned to variables etc. See: https://wiki.haskell.org/Constructor
Merge class and type contexts as it is not possible to reliably distinguish both in all situations anyway. The common scope `storage.type` ensures same highlighting under all circumstances.
This commit... 1. adds some infrastructure to make sure to correctly match `[context] =>` patterns in class/instance/data/type/newtype declarations. It's required to reliably match the beginning of data constructors. 2. removes `entity.name.class` scoping from instance declarations as this was semantically wrong.
This commit limits fully qualified data type matching to 1 after `deriving` keywords, in case they are not surrounded by parens. More reliably pop as soon as possible.
This commit adds data constructor expressions in order to 1. scope constructors `entity.name.constructor` in declarations. 2. add declared constructor names to Symbol List. 3. enable "Goto Definition" It should improve readability of constructor expressions as the declared constructor may be tinted differently then the following types which define its signature.
jrappen
approved these changes
Feb 21, 2022
michaelblyons
approved these changes
Apr 2, 2022
jfcherng
approved these changes
Apr 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses some points from #3227.
Just,Nothing,LeftandRightare highlighted consistently.entity.name.constant.[context] =>expresssions in class/data/newtype/type declarations had to be changed a bit to (more) reliably. It is mainly required to detect the beginning of data constructor expressions (= Constr), but also helps with some edge cases in the other declarations.Note: This PR does not scope data types and data constructors differently in normal statements/expressions as no reliable strategy hasn't been found to do so.