Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C#] support class definitions without a body #4120

Merged
merged 3 commits into from
Jan 9, 2025
Merged

[C#] support class definitions without a body #4120

merged 3 commits into from
Jan 9, 2025

Conversation

keith-hall
Copy link
Collaborator

@keith-hall keith-hall commented Dec 26, 2024 •
edited
Loading

fixes #4119

plus converts some anonymous contexts into named contexts

michaelblyons
michaelblyons previously approved these changes Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@michaelblyons michaelblyons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine for the conversations to play out, but this is an improvement.

@deathaxe
Copy link
Collaborator

deathaxe commented Jan 7, 2025

It however changes inherit class parameter list's scope to meta.function-call.arguments without even adding meta.function-call scope to the inherit class name, which is inconsistent and IMHO not correct.

This syntax denotes inheritance definitions, but no function calls.

michaelblyons
michaelblyons previously approved these changes Jan 8, 2025
View reviewed changes
@keith-hall keith-hall merged commit 553c203 into sublimehq:master Jan 9, 2025
1 check passed
@keith-hall keith-hall deleted the cs_4119 branch January 9, 2025 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deathaxe deathaxe deathaxe approved these changes

@michaelblyons michaelblyons michaelblyons approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[C#] Primary constructors on raw classes without a body
3 participants
@keith-hall @deathaxe @michaelblyons