[SQL] move heuristics for SQL inside Python and PHP strings to common syntax #4134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TBH, that doesn't feel right. What if there were 2 or 3 such constructs. We would barely inherit from them at the same time. Currently, if SQL is disabled/missing, only SQL strings keep plain. With this change whole syntax is driven nonworking. IMHO, that's not worth it. |
|
good point, I hadn't considered behavior while a package is disabled. Thanks, closing :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just a random idea I had when thinking about having SQL highlighting inside C# strings, so I thought I'd open a PR to get opinions...