Add initial implementation

[niksy]

As per sublimelsp/repository#124, this PR adds initial implementation for language server.

[predragnikolic]

Add a step to install the Twig Syntax here -> https://packagecontrol.io/packages/Twig.

[niksy]

Done!

[rchl]

I don't know how important that functionality is but I see that the VSCode extension has client-side logic to request (additional?) completions from the server for the virtual embedded-content schema: https://github.com/moetelo/twiggy/blob/1e9acaeb47e8887a69181ebe5cc418392afba3be/packages/vscode/src/extension.ts#L136-L143
Looks like completions for the HTML parts of the template or something.

[niksy]

I don't know how important that functionality is but I see that the VSCode extension has client-side logic to request (additional?) completions from the server for the virtual embedded-content schema: moetelo/twiggy@1e9acae/packages/vscode/src/extension.ts#L136-L143 Looks like completions for the HTML parts of the template or something.

Haven’t seen any issues with this, all other buggy stuff has already been submitted as issue by me or someone else, so maybe this will also be addressed as part of making language server more non-VS Code friendly.

[rchl]

I've submitted moetelo/twiggy#54 btw (unrelated to my previous comment).

To make file watching work for now, you can manually register it - see https://github.com/sublimelsp/LSP-eslint/blob/356d5b3d0ff86647481f9bebf37185804e5ca1d4/LSP-eslint.sublime-settings#L128-L134

[rchl]

I don't know how important that functionality is but I see that the VSCode extension has client-side logic to request (additional?) completions from the server for the virtual embedded-content schema: moetelo/twiggy@1e9acae/packages/vscode/src/extension.ts#L136-L143 Looks like completions for the HTML parts of the template or something.

Haven’t seen any issues with this, all other buggy stuff has already been submitted as issue by me or someone else, so maybe this will also be addressed as part of making language server more non-VS Code friendly.

I believe this functionality just makes sure that HTML-specific completions are provided when outside of twig templates.

[moetelo]

this functionality just makes sure that HTML-specific completions are provided when outside of twig templates.

That's correct. The purpose of the entire provideCompletionItem middleware is to query the Twiggy LSP to check whether we're in Twig context. If we're not in Twig, it then assumes we're in HTML and requests additional HTML completions from VS Code's HTML LSP.

---

By "HTML context," I mean:

some-file.twig

<div> | </div>

By "Twig context," I mean:

some-file.twig

<div>{{ | }}</div>

[rchl]

I see. That's very VSCode-specific approach. Ideally the server would bundle the html service and utilize that directly. But oh well, it doesn't seem essential.

(In theory one can run both LSP-html and LSP-twiggy at the same time but I suppose that might create unnecessary completions within context of interpolations)

[rchl]

I've submitted moetelo/twiggy#54 btw (unrelated to my previous comment).

To make file watching work for now, you can manually register it - see sublimelsp/LSP-eslint@356d5b3/LSP-eslint.sublime-settings#L128-L134

@niksy can you make that change in the mean time?

[niksy]

@rchl done!