Effective from #42
Open
Effective from #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalabukdima
reviewed
Jan 8, 2025
| @@ -24,6 +24,8 @@ use crate::scheduler::Scheduler; | |||
| use crate::scheduling_unit::{bundle_chunks, SchedulingUnit}; | |||
| use sqd_messages::assignments::{Assignment, NetworkAssignment, NetworkState}; | |||
|
|
|||
| const ASSIGNMENT_EFFECTIVE_FROM_TIMEOUT_SEC: u64 = 30; | |||
There was a problem hiding this comment.
It's not actually a timeout, let's call it "delay" or smth like that
| @@ -334,11 +336,19 @@ impl S3Storage { | |||
| } | |||
| } | |||
|
|
|||
| let system_time = std::time::SystemTime::now(); | |||
| let mut effective_from = system_time | |||
There was a problem hiding this comment.
Please try to avoid mutating variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.