tests: enable tests related to bitwise_or.test (#116)

substrait-io · Feb 5, 2025 · 627598e · 627598e
1 parent f53a037
commit 627598e
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 5 deletions.
diff --git a/extensions/variants_test.go b/extensions/variants_test.go
@@ -216,8 +216,7 @@ func TestMatchWithSyncParams(t *testing.T) {
 		funcType parser2.TestFuncType
 		numTests int
 	}{
-		// TODO enable bitwise_or.test after fixing the testcase file
-		//{"tests/cases/arithmetic_decimal/bitwise_or.test", parser2.ScalarFuncType, 14},
+		{"tests/cases/arithmetic_decimal/bitwise_or.test", parser2.ScalarFuncType, 14},
 		{"tests/cases/arithmetic_decimal/bitwise_xor.test", parser2.ScalarFuncType, 14},
 		{"tests/cases/arithmetic_decimal/bitwise_and.test", parser2.ScalarFuncType, 14},
 		{"tests/cases/arithmetic_decimal/sqrt_decimal.test", parser2.ScalarFuncType, 14},

diff --git a/testcases/parser/parse_test.go b/testcases/parser/parse_test.go
@@ -707,9 +707,6 @@ func TestLoadAllSubstraitTestFiles(t *testing.T) {
 			case "tests/cases/datetime/extract.test":
 				// TODO deal with enum arguments in testcase
 				t.Skip("Skipping extract.test")
-			case "tests/cases/arithmetic_decimal/bitwise_or.test":
-				// TODO enable this after merging the PR with testcase fix
-				t.Skip("Skipping bitwise_or.test")
 			}
 
 			testFile, err := ParseTestCaseFileFromFS(got, filePath)