Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tweak the not found in dialect message #107

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

EpsilonPrime
Copy link
Member

No description provided.

@EpsilonPrime EpsilonPrime requested a review from scgkiran January 20, 2025 23:35
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.11%. Comparing base (78fdc19) to head (074b73a).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #107      +/-   ##
==========================================
+ Coverage   62.94%   63.11%   +0.16%     
==========================================
  Files          44       44              
  Lines       10281    10388     +107     
==========================================
+ Hits         6471     6556      +85     
- Misses       3523     3539      +16     
- Partials      287      293       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vqmarkman
Copy link

PR addresses this problem: https://sundeck.atlassian.net/browse/SD-9378

functions/dialect.go Outdated Show resolved Hide resolved
@EpsilonPrime EpsilonPrime merged commit d4f8747 into substrait-io:main Jan 21, 2025
8 checks passed
@EpsilonPrime EpsilonPrime deleted the typemsg branch January 21, 2025 03:46
@EpsilonPrime EpsilonPrime restored the typemsg branch January 21, 2025 03:46
@EpsilonPrime EpsilonPrime deleted the typemsg branch January 21, 2025 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants