fix: set nullability correctly in testcase parser #110
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #110 +/- ##
==========================================
- Coverage 63.04% 63.03% -0.01%
==========================================
Files 44 44
Lines 10610 10627 +17
==========================================
+ Hits 6689 6699 +10
- Misses 3621 3628 +7
Partials 300 300 ☔ View full report in Codecov by Sentry. |
| {testCaseStr: "f20(('abcd', 'ef')::varchar<9>) = Null::vchar<9>", expTestStr: "f20(('abcd', 'ef')::varchar<9>) = null::varchar<9>"}, | ||
| {testCaseStr: "f20(('abcd', 'ef')::fbin<9>) = Null::fbin<9>", expTestStr: "f20(('abcd', 'ef')::fixedbinary<9>) = null::fixedbinary<9>"}, | ||
| {testCaseStr: "f20(('abcd', 'ef')::fixedbinary?<9>) = Null::fixedbinary<9>", expTestStr: "f20(('abcd', 'ef')::fixedbinary?<9>) = null::fixedbinary<9>"}, | ||
| {testCaseStr: `DEFINE t1(varchar<5>) = (('cat'), ('bat'), ('rat'), (null)) |
There was a problem hiding this comment.
Should this be varchar<5>??
There was a problem hiding this comment.
The type is associated with column argument, in this case number of arguments is zero.
Added another test with one argument
There was a problem hiding this comment.
It looks like null is one of the possible values but varchar<5> isn't nullable. That seems like something that should cause an error.
There was a problem hiding this comment.
That needs, substrait PR for grammar changes to be merged, to handle all cases. Currently we have ? support only for composite types.
No description provided.