Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AggregateRel.CopyWithExpressionRewrite to rewrite measure functions in addition to filters #112

Merged
merged 8 commits into from
Jan 29, 2025

Conversation

EpsilonPrime
Copy link
Member

No description provided.

@EpsilonPrime EpsilonPrime changed the title git logSD-9457 SD-9457: Update AggregateRel.CopyWithExpressionRewrite to rewrite measure functions in addition to filters Jan 29, 2025
@EpsilonPrime EpsilonPrime requested a review from scgkiran January 29, 2025 09:23
@EpsilonPrime EpsilonPrime marked this pull request as draft January 29, 2025 09:45
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 36.58537% with 26 lines in your changes missing coverage. Please review.

Project coverage is 63.53%. Comparing base (d6e63d9) to head (d36bac9).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
expr/functions.go 0.00% 17 Missing ⚠️
plan/relations.go 62.50% 6 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #112      +/-   ##
==========================================
- Coverage   63.64%   63.53%   -0.11%     
==========================================
  Files          44       44              
  Lines       10819    10858      +39     
==========================================
+ Hits         6886     6899      +13     
- Misses       3621     3644      +23     
- Partials      312      315       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EpsilonPrime EpsilonPrime marked this pull request as ready for review January 29, 2025 10:17
@EpsilonPrime EpsilonPrime changed the title SD-9457: Update AggregateRel.CopyWithExpressionRewrite to rewrite measure functions in addition to filters Update AggregateRel.CopyWithExpressionRewrite to rewrite measure functions in addition to filters Jan 29, 2025
@EpsilonPrime EpsilonPrime merged commit 60cc74f into substrait-io:main Jan 29, 2025
6 of 8 checks passed
@EpsilonPrime EpsilonPrime deleted the expression_rewrites branch January 29, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants