feat: Add AggregateRel.ToBuilder()

[EpsilonPrime]

No description provided.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.61%. Comparing base (60cc74f) to head (7e1e556).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #114      +/-   ##
==========================================
+ Coverage   63.53%   63.61%   +0.07%     
==========================================
  Files          44       44              
  Lines       10858    10876      +18     
==========================================
+ Hits         6899     6919      +20     
+ Misses       3644     3642       -2     
  Partials      315      315              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jacques-n]

If I use ToBuilder(), how do I then override measures and/or input?

[EpsilonPrime]

If I use ToBuilder(), how do I then override measures and/or input?

Hmm, true. The builder doesn't have a way to get rid of the existing measures. The cleanest way would be to provide a clear method. The builder doesn't have a way to change the input but AggregateRel.Copy allows the input to change. I propose adding:

AggregateRelBuilder.ReplaceInput
AggregateRelBuilder.ClearMeasures
AggregateRelBuilder.ClearGroupings (affects both grouping references and grouping expressions)

[jacques-n]

What about replacing measures? (That's my specific use case.)

[EpsilonPrime]

What about replacing measures? (That's my specific use case.)

If I implement AggregateRelBuilder.ClearMeasures you could first clear them all and then add all of the desired measures (including old ones) next. If you want to directly replace the third measure I could add AggregateRelBuilder.SetMeasure(index int, measure).

[EpsilonPrime]

What about replacing measures? (That's my specific use case.)

If I implement AggregateRelBuilder.ClearMeasures you could first clear them all and then add all of the desired measures (including old ones) next. If you want to directly replace the third measure I could add AggregateRelBuilder.SetMeasure(index int, measure).

@jacques-n Is Clear() sufficient for your purposes or would you like SetMeasure() as well?