Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use downloadable go directive 1.22.0 #1967

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

mattsse
Copy link
Contributor

@mattsse mattsse commented Jan 22, 2025

Motivation

Caused by:
process didn't exit successfully: /Users/Matthias/git/rust/sp1/target/debug/build/sp1-recursion-gnark-ffi-5c63451eec7e8a67/build-script-build (exit status: 101)
--- stdout
cargo:rerun-if-changed=go
Building Go library at /Users/Matthias/git/rust/sp1/target/debug/build/sp1-recursion-gnark-ffi-d2e6560ead9a758e/out/libsp1gnark.a

--- stderr
go: downloading go1.22 (darwin/arm64)
go: download go1.22 for darwin/arm64: toolchain not available

Solution

according to golang/go#65568 (comment)

go 1.22 without a more specific toolchain directive is not sufficient.

golang/go#62278 (comment)

this is as expected: go 1.21 was a development version of the language, for which there is no downloadable release (because it is not a specific version). The release version would be go 1.21.0.

see also: https://go.dev/doc/devel/release#go1.22.0

I assume the CI "go-version: "1.22"" is fine because the action handles this?

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@leruaa leruaa self-assigned this Jan 28, 2025
Copy link
Contributor

@leruaa leruaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty!

@leruaa leruaa merged commit 41d6a78 into succinctlabs:dev Jan 28, 2025
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants