feat(precompile): add bn254 precompile #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 0xkanekiken <[email protected]>
Signed-off-by: 0xkanekiken <[email protected]>
Signed-off-by: 0xkanekiken <[email protected]>
Signed-off-by: 0xkanekiken <[email protected]>
Signed-off-by: 0xkanekiken <[email protected]>
0xkanekiken
force-pushed
the
kaneki-bn254-precompile
branch
from
eff4894 to
e977a32
Compare
Signed-off-by: 0xkanekiken <[email protected]>
Signed-off-by: 0xkanekiken <[email protected]>
puma314
reviewed
Mar 19, 2024
zkvm/precompiles/src/bn254.rs
Outdated
| } | ||
|
|
||
| impl Bn254AffinePoint { | ||
| pub fn from(x: [u32; 8], y: [u32; 8]) -> Self { |
There was a problem hiding this comment.
can we reuse code with the other AffinePoint? this seems like a lot of this copy-pasted from another file
There was a problem hiding this comment.
please let me know on your thoughts on https://github.com/succinctlabs/sp1/pull/384/files#diff-dd2618465bbb8d8253e07f153eae3ec526ce00926191f797ff418ed4d710dc0f
Signed-off-by: 0xkanekiken <[email protected]>
|
Just an update on the VM cycles: |
ctian1
reviewed
Mar 19, 2024
Signed-off-by: 0xkanekiken <[email protected]>
Signed-off-by: 0xkanekiken <[email protected]>
Signed-off-by: 0xkanekiken <[email protected]>
Signed-off-by: 0xkanekiken <[email protected]>
ctian1
approved these changes
Mar 26, 2024
puma314
requested changes
Mar 26, 2024
ctian1
reviewed
Mar 26, 2024
Signed-off-by: 0xkanekiken <[email protected]>
Signed-off-by: 0xkanekiken <[email protected]>
Signed-off-by: 0xkanekiken <[email protected]>
Signed-off-by: 0xkanekiken <[email protected]>
puma314
reviewed
Mar 27, 2024
puma314
reviewed
Mar 27, 2024
Signed-off-by: 0xkanekiken <[email protected]>
Signed-off-by: 0xkanekiken <[email protected]>
Signed-off-by: 0xkanekiken <[email protected]>
puma314
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
bn254curve'saddanddoubleoperations by leveraging the existingweierstrassprecompile.bn254_mulby leveragingbn254_addandbn254_double. One operation ofbn254is taking 3,806,937 vm cycles.