Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use docker by default for gnark #890

Merged
merged 21 commits into from
Jun 7, 2024
Merged

feat: use docker by default for gnark #890

merged 21 commits into from
Jun 7, 2024

Conversation

ctian1
Copy link
Member

@ctian1 ctian1 commented Jun 5, 2024

  • plonk feature is now native-gnark in sdk and prover. In gnark-ffi the plonk feature is now native
  • recursion/gnark-cli crate calls native gnark functions as a simple cli
  • When not using native-gnark, Docker is used instead of panicking
  • Build gnark docker image in CI
  • Separate docker test in CI because main tests in docker dont work well concurrently

CLI code adopted from #866

@ctian1 ctian1 force-pushed the chris/ffi-docker branch from 68aaa06 to 414fdd9 Compare June 5, 2024 19:12
@ctian1 ctian1 marked this pull request as ready for review June 6, 2024 22:39
@ctian1 ctian1 merged commit 03c71ae into dev Jun 7, 2024
6 checks passed
@ctian1 ctian1 deleted the chris/ffi-docker branch June 7, 2024 23:33
@@ -0,0 +1,10 @@
[workspace]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants